upgrade to rust v1.54.0 #12459
Merged
upgrade to rust v1.54.0 #12459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
approved these changes
Jul 29, 2021
illicitonion
approved these changes
Jul 29, 2021
added 7 commits
July 29, 2021 21:31
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
error: this expression borrows a reference (`&std::collections::BTreeSet<<R as rules::Rule>::TypeId>`) that is immediately dereferenced by the compiler
--> rule_graph/src/builder.rs:619:35
|
619 | .map(|out_set| params_str(&out_set))
| ^^^^^^^^ help: change this to: `out_set`
|
note: the lint level is defined here
--> rule_graph/src/builder.rs:7:3
|
7 | clippy::all,
| ^^^^^^^^^^^
= note: `#[deny(clippy::needless_borrow)]` implied by `#[deny(clippy::all)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&Workunit`) that is immediately dereferenced by the compiler
--> workunit_store/src/lib.rs:456:56
|
456 | let maybe_duration = Self::duration_for(now, &workunit);
| ^^^^^^^^^ help: change this to: `workunit`
|
note: the lint level is defined here
--> workunit_store/src/lib.rs:7:3
|
7 | clippy::all,
| ^^^^^^^^^^^
= note: `#[deny(clippy::needless_borrow)]` implied by `#[deny(clippy::all)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this pattern creates a reference to a reference
--> workunit_store/src/lib.rs:537:17
|
537 | if let Some(ref workunit) = workunit {
| ^^^^^^^^^^^^ help: try this: `workunit`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[ci skip-build-wheels]
more deref stuff
[ci skip-build-wheels]
[ci skip-build-wheels]
tdyas
force-pushed
the
upgrade_to_rust_v1.54.0
branch
from
4c9b310 to
1611224
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Rust v1.54.0. Announcement
Changes to satisfy Clippy:
needless_collectin two places since making the suggested change resulted in a borrow checker error.Dropimpl later that would otherwise be dead code and need '#[allow(dead_code)]`.