Add support for the check goal for javac
#12859
Conversation
stuhood
force-pushed
the
stuhood/check-java
branch
2 times, most recently
from
379dc54 to
cf2d675
Compare
| # Copyright 2021 Pants project contributors (see CONTRIBUTORS.md). | ||
| # Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
|
||
| java_library( | ||
| dependencies=[ | ||
| ":lockfile", | ||
| ], | ||
| ) | ||
|
|
||
| coursier_lockfile( | ||
| name = "lockfile", | ||
| maven_requirements = [], | ||
| sources = [ | ||
| "coursier_resolve.lockfile", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Echoing feedback I received on a previous review: is testprojects not now discouraged?
There was a problem hiding this comment.
I'm still not a big fan because it results in brittle tests, multiple of them depending on the same fixture.
There was a problem hiding this comment.
There are no tests depending on it. I could move it under examples? I find it easier in many cases to iterate on fixing issues outside of the test harness (...should probably invest time in fixing that, but).
There was a problem hiding this comment.
Yeah I do agree there, I've found it useful for Go too. But then we get into a situation if we don't have tests where we risk bit rot 🤔
Maybe the solution is have them, but don't rely on them for intricate testing like we did in v1?
There was a problem hiding this comment.
Will leave this here, and have added a test.
[ci skip-rust] [ci skip-build-wheels]
| def level(self) -> LogLevel: | ||
| return LogLevel.ERROR if self.exit_code != 0 else LogLevel.INFO | ||
|
|
||
| def message(self) -> str: |
There was a problem hiding this comment.
Known issue: until #12877 has landed, this will only render the first time it fails, and not if it hits cache.
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/check-java
branch
from
cf2d675 to
eb56cea
Compare
Add a `cacheable` flag to `EngineAwareReturnType` to ease forcing the sideeffects of `EngineAware` types. #12859 will use this to force re-rendering of failed (but not successful) compile outputs. Additionally: clarify the meaning of "can_modify_workunit" by renaming it to `engine_aware_return_type`, and remove redundancy of `impl`s. [ci skip-build-wheels]
Add support for the
checkgoal by making the result ofjavaccompilation aFallibleCompiledClassfilestype so that results are streamed, and the compilation graph can (optionally) complete without raising an exception.Successful check:
Failed check:
