[internal] Remove test cache isolation #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
force-pushed
the
stuhood/remove-test-cache-isolation
branch
from
ad81972 to
f3ba750
Compare
|
|
stuhood
force-pushed
the
stuhood/remove-test-cache-isolation
branch
2 times, most recently
from
f43c76e to
b70453d
Compare
[ci skip-build-wheels] [ci skip-rust]
stuhood
force-pushed
the
stuhood/remove-test-cache-isolation
branch
from
b70453d to
7afc8b5
Compare
|
This is ready for review: it's run three times without any flakes of the form that we used to see before #13046. |
patricklaw
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #13336 fixed, we should be able to remove
RuleRunnercache directory isolation.Thanks a lot to @patricklaw for the upstream fix in coursier/coursier#2197, and @alexarchambault for his work getting out a new coursier release!
[ci skip-rust]
[ci skip-build-wheels]