go: introduce _go_sdk and _go_sdk_package target types for SDK analysis #17973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
backend: Go
stuhood
approved these changes
Jan 11, 2023
tdyas
added a commit
that referenced
this pull request
Jan 12, 2023
Add Go to wheel building jobs to work around issue where Pants is looking for `go`. Example errors here: https://github.com/pantsbuild/pants/actions/runs/3905384605/jobs/6672312872 After landing #17973, Pants now generates a synthetic target to represent the Go SDK. That target type is a target generator and eagerly calls `go` to find out what targets to generate for the Go SDK. The wheel building jobs were missing Go, so boom.
|
FYI This breaks for any Pants dev that doesn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
_go_sdkand_go_sdk_packagetarget types to allow the build graph to represent the structure of a Go SDK._go_sdktarget type is used to create a synthetic target//:default_go_sdkto represent the Go SDK found using the[golang].go_search_pathsoption. This target type is a target generator and generates a_go_sdk_packagetarget for each SDK package._go_sdk_packagetarget type is used as the target type for each target representing a SDK package.This is part of fixing #17950 and was extracted from #17914.