Remove potential for panics from spawn APIs #17974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
added
the
category:internal
This comment was marked as outdated.
This comment was marked as outdated.
…l make race conditions around Scheduler shutdown safe.
stuhood
force-pushed
the
stuhood/spawn-no-panic
branch
from
1248e2f
to
c1d6397
Compare
tdyas
approved these changes
Jan 13, 2023
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jan 16, 2023
This reverts commit a97f9c2.
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Jan 16, 2023
This reverts commit a97f9c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #16105, we will likely want to replace the global static
ExecutorwithExecutors that are created per-Scheduler. That would introduce shutdown race conditions which given our currentunwrap'ing intask_executorcould lead to panics.This change adjusts
task_executor'sspawnAPIs to avoid panicing by converting task errors into the expected error/result type at each callsite.