Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: use preexisting constant for testmain filename #17988

Merged
merged 1 commit into from
Jan 13, 2023
Merged

go: use preexisting constant for testmain filename #17988

merged 1 commit into from
Jan 13, 2023

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Jan 13, 2023

Missed a spot when switching over to a constant for the name of the generated "testmain" file.

@tdyas tdyas added backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Jan 13, 2023
@tdyas tdyas requested review from stuhood and benjyw January 13, 2023 00:25
@tdyas tdyas enabled auto-merge (squash) January 13, 2023 07:10
@tdyas tdyas merged commit 0238a66 into pantsbuild:main Jan 13, 2023
@jsirois jsirois mentioned this pull request Jan 14, 2023
Merged
@tdyas tdyas deleted the golang_use_test_constant branch February 20, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@stuhood stuhood Awaiting requested review from stuhood

Assignees
No one assigned
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdyas @benjyw