-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flaky failure in export_integration_test.py
#21756
Conversation
Below is the text of the Note the relevant part is Yet, the existing test looks for
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.24.xSuccessfully opened #21820. Thanks again for your contributions! |
) (#21820) `src/python/pants/backend/python/goals/export_integration_test.py` was failing for me consistently in a PR of mine and on `main` locally. Not sure why it passes elsewhere. See this failure for example: https://github.com/pantsbuild/pants/actions/runs/12306576175/job/34349676205?pr=21745#step:10:478 The test is checking whether a venv activation script has a certain prompt with both a resolve name and the Python version. The test also checks whether the quote character starting that string begins with a double-quote character. On my system for `main` and in the PR on CI, that quote character became a single quote instead so the test fails. Use a regex and allow either quote character. Co-authored-by: Tom Dyas <tom@shoalsoftware.com>
) (#21821) `src/python/pants/backend/python/goals/export_integration_test.py` was failing for me consistently in a PR of mine and on `main` locally. Not sure why it passes elsewhere. See this failure for example: https://github.com/pantsbuild/pants/actions/runs/12306576175/job/34349676205?pr=21745#step:10:478 The test is checking whether a venv activation script has a certain prompt with both a resolve name and the Python version. The test also checks whether the quote character starting that string begins with a double-quote character. On my system for `main` and in the PR on CI, that quote character became a single quote instead so the test fails. Use a regex and allow either quote character. Co-authored-by: Tom Dyas <tom@shoalsoftware.com>
src/python/pants/backend/python/goals/export_integration_test.py
was failing for me consistently in a PR of mine and onmain
locally. Not sure why it passes elsewhere.See this failure for example: https://github.com/pantsbuild/pants/actions/runs/12306576175/job/34349676205?pr=21745#step:10:478
The test is checking whether a venv activation script has a certain prompt with both a resolve name and the Python version. The test also checks whether the quote character starting that string begins with a double-quote character.
On my system for
main
and in the PR on CI, that quote character became a single quote instead so the test fails.Use a regex and allow either quote character.