store all known releases for Python Build Standalone known versions #21776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import json
import re
import sys
with open(sys.argv[1]) as f:
data = json.load(f)
DIGITS_RE = re.compile("^\d+")
python_versions_to_delete = []
for python_version, releases_for_python in data["pythons"].items():
releases_to_delete = []
for release_name, platforms_for_release in releases_for_python.items():
if not DIGITS_RE.match(release_name):
releases_to_delete.append(release_name)
for release_name in releases_to_delete:
del releases_for_python[release_name]
if not releases_for_python:
python_versions_to_delete.append(python_version)
for python_version in python_versions_to_delete:
del data["pythons"][python_version]
with open(sys.argv[1], 'w') as f:
f.write(json.dumps(data, sort_keys=True, indent=2))
|
It is helpful to review the commits individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first mentioned by @huonw in #21710 (review) and more fully discussed in #21748, the addition of filtering PBS releases by the PBS release tag means that users may now see a breaking change if Pants scrapes newer versions of PBS releases, replaces some of the existing "known versions" data with the newly-scraped release metadata, and the user selects an older release via a PBS release constraint.
In that case, the user would see an error because Pants would be unable to select that specific PBS version anymore due to no longer having any metadata regarding that PBS release tag.
The solution is for Pants to store metadata for all PBS release tags. Newer versions will only add to the PBS "known versions" data and not replace nor delete any metadata. With all metadata available, a user who selects a particular PBS release via the release constraints will still continue to see that release be selected. And users who want the latest matching PBS release will continue to get the latest PBS release (known to Pants).
Closes #21748.