Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface stages in Dockerfiles which do not have tags #21892

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

lilatomic
Copy link
Contributor

@lilatomic lilatomic commented Jan 29, 2025

This MR surfaces Docker stages which do not have tags (using only a hash). For example, FROM gcr.io/distroless/python3-debian12@sha256:8e432c787b5c0697dfbfd783120351d90fd5f23ba9fff29532bbdbb87bc13160 AS runtime can now be used in the docker_image.target_stage. This is implemented in both the legacy and rust-based parsers.

fixes #21850

@lilatomic lilatomic added category:bugfix Bug fixes for released features backend: Docker Docker backend-related issues labels Jan 29, 2025
@lilatomic lilatomic requested a review from tobni January 29, 2025 21:51
This allows stages which use a hash with no tag to be targeted.
This allows stages which use a hash with no tag to be targeted.
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks for fixing!

@lilatomic lilatomic merged commit f72df85 into pantsbuild:main Feb 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Docker Docker backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pants can't build multi stage Docker image with named stage and image digest
2 participants