perform tilde expansion on path_metadata_request #21900
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the pants repo itself, the inputs to `path_metadata_request` are commonly used on the components of the `PATH` variable. These would presumable be valid paths, but people have all sorts of crusty oddities in their shell configs. In particular if one does something reasonable looking like `export PATH="~/.local/bin:$PATH"` (note the quotes) than the path component will be a literal `~/.local/bin` and not expanded to the home directory. This is because tilde expansion happened *before* <https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06> the quote removal. Since bash and friends are cool fine with literal tildes in `PATH`, everyone would reasonable expect pants to be too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the pants repo itself, the inputs to
path_metadata_requestare commonly used on the components of thePATHvariable. These would presumable be valid paths, but people have all sorts of crusty oddities in their shell configs.In particular if one does something reasonable looking like
export PATH="~/.local/bin:$PATH"(note the quotes) than the path component will be a literal~/.local/binand not expanded to the home directory. This is because tilde expansion happened before https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06 the quote removal.Since bash and friends are cool fine with literal tildes in
PATH, everyone would reasonable expect pants to be too.