Code

Run clippy with nightly rust on CI#6347

Code

Merged

stuhood merged 22 commits intopantsbuild:masterpantsbuild/pants:masterfrom twitter:dwagnerhall/clippy-alltwitter/pants:dwagnerhall/clippy-allCopy head branch name to clipboardAug 16, 2018

+484-167

Commits

Commits on Aug 15, 2018

• Remove calls to std::env::home_dir

  Show description for ee76109
  illicitonion

  committed
  ee76109

• Ensure temporary is kept alive while used

  illicitonion

  committed
  7126602

• Split on char not string

  illicitonion

  committed
  29a2e67

• Remove redundant returns

  illicitonion

  committed
  6a043aa

• Don't clone things which are Copy

  illicitonion

  committed
  317b2b9

• Sleep in loop

  Show description for 50fa388
  illicitonion

  committed
  50fa388

• Take reference to slice

  illicitonion

  committed
  dd192fd

• Take reference

  illicitonion

  committed
  1acc911

• Use if instead of match or map

  illicitonion

  committed
  a24a3e3

• Extract inline function

  illicitonion

  committed
  f298015

• Take cheaper or value or reference

  illicitonion

  committed
  742c6e0

• Remove redundant into_iter()

  illicitonion

  committed
  6fa34e4

• Use +=

  illicitonion

  committed
  9c6cb03

• Invert ifs

  illicitonion

  committed
  925abd0

• Don't use useless format

  illicitonion

  committed
  7e89c61

• Don't use _ for used variable

  illicitonion

  committed
  546d818

• Use closure, rather than unconditionally executing

  illicitonion

  committed
  16181ac

• Add check for negative timeout

  illicitonion

  committed
  f4d2fc7

• Enable clippy for all crates except bazel_protos

  illicitonion

  committed
  5822447

• CI runs clippy

  illicitonion

  committed
  2620afa

• Actually run clippy on CI

  illicitonion

  committed
  bc1cf56

• Install fuse

  illicitonion

  committed
  14a1a68