-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module not found: Can't resolve 'jose/jwt/sign' #193
Comments
works 🎉
I am unable to provide solutions for non-standard loaders or ecosystems that chose to build their own loaders are not keeping them up to date with node's own module resolution algorithm. |
I'm solving this problem by importing the relevant files directly. I put this into an intermediate file import type * as T_SignJWT from 'jose/dist/types/jwt/sign'
export const { default: SignJWT } = require('jose/dist/node/cjs/jwt/sign') as typeof T_SignJWT
import type * as T_jwtVerify from 'jose/dist/types/jwt/verify'
export const { default: jwtVerify } = require('jose/dist/node/cjs/jwt/verify') as typeof T_jwtVerify And then I can use it like this: import { SignJWT } from './jose' Yes I know I'm relying on internals here, but if it breaks, I can quickly fix it by editing one file on my end. |
In my experience, this can be caused by a missing "main" key in the package.json file, which is see is missing in 3.11.6. But also, the paths in the documentation don't exist, so I don't see how the import would ever work as documented: https://unpkg.com/browse/jose@3.11.6/ > var {jwtVerify} = require("jose/jwt/verify");
// Thrown:
{ Error: Cannot find module 'jose/jwt/verify'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Module.require (internal/modules/cjs/loader.js:692:17)
at require (internal/modules/cjs/helpers.js:25:18) code: 'MODULE_NOT_FOUND' } Obviously there is no JS module at Am I missing something here? |
There's no "main" entry because there's no "main" package or export. It's just submodules, using a node loader feature present in the supported runtimes. Tooling is slowly catching up, but is just not quite there yet.
Well, clearly they do - there are plenty of consumers of this package major already. Plus, see the proof of working code i've posted above.
https://nodejs.org/api/packages.html#packages_subpath_exports |
Yes, that's why I thought I was missing something... Taking a look at the "exports" docs now, I've somehow not come across this before. I'm still stuck on nodejs 10 (and node loader support was added in 12) so I might need to use @tellnes's workaround for now. Thanks for the quick reply. |
Well, node 10 is not a supported runtime. Not only because of the module features. But crypto itself requires node 12. |
I did notice that (after commenting). What about adding an https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines |
I'm aware of the |
I see what you mean (eg installing with nodejs, but intended use for browser), but it's only advisory unless you use
But I only make a suggestion. |
Can you elaborate, I'm afraid I don't quite follow. |
Sorry, ignore that sentence. I thought I had tested the functionality I needed working with nodejs 10, but I was still using 12.
Because of |
I have this error in a standard create-react-app typescript setup. I think this should be re-opened and investigated. |
Same issue here when using the package with a vue-cli setup:
Using node v14.17.0 |
typescript support for the node's ESM module loader is in the works - microsoft/TypeScript#44501 |
To bypass this problem with typescript, I added a alias path to the typescript config: {
"compilerOptions": {
"paths": {
"jose/jwt/*": ["node_modules/jose/dist/browser/jwt/*"]
}
}
}
|
Any updates on this one? I'm getting the same error with create-react-app typescript. |
@dalegacusan you're barking up the wrong tree - this is to be solved in your tooling, not here. |
FWIW |
Does anyone have this working with a "current" TypeScript / Node setup (i.e. not yet using ESM, because its somewhat of a struggle with the rest of the TS ecosystem) I think the only fix I can see is to manually hack around the existing type definitions as in #193 (comment) This is mildly disappointing because the library author seems to have made an effort to ship / maintain typedefs, but they're not usable in a Node setup from what I can see so far. Happy to be corrected 😄 |
@robcresswell I really don't understand the struggles here. Not only was I able to make almost anything I wanted work https://github.com/panva/it-should-just-work, but there's TS 4.5 on the horizon with full fledged support now. |
@panva https://github.com/robcresswell/jose-193 is a minimal repro of what I'm seeing, if that helps I realise the code itself is nonsense, but the issue is an import path one, not a code one, I think. Also I'm aware there's a good chance I'm being an idiot here, so apologies in advance if I'm wasting your time. |
@robcresswell all taken from the linked https://github.com/panva/it-should-just-work diff --git a/main.ts b/main.ts
index 1b7ab92..965dbcc 100644
--- a/main.ts
+++ b/main.ts
@@ -4,6 +4,6 @@ export function main() {
const encoded = new TextEncoder().encode('');
new CompactEncrypt(encoded)
- .setProtectedHeader({ alg: 'RSA-OAEP-256', enc: 'A256GCM' })
- .encrypt(Buffer.from(''));
+ .setProtectedHeader({ alg: 'dir', enc: 'A256GCM' })
+ .encrypt(Buffer.alloc(32));
}
diff --git a/package.json b/package.json
index 84a3d6d..22ead9e 100644
--- a/package.json
+++ b/package.json
@@ -4,12 +4,13 @@
"description": "",
"main": "index.js",
"scripts": {
- "test": "jest"
+ "test": "jest --resolver='./temporary_resolver.js'"
},
"author": "",
"license": "MIT",
"devDependencies": {
"@types/jest": "^27.0.2",
+ "enhanced-resolve": "^5.8.3",
"jest": "^27.2.5",
"ts-jest": "^27.0.5",
"typescript": "^4.4.3"
diff --git a/temporary_resolver.js b/temporary_resolver.js
new file mode 100644
index 0000000..eeba8ba
--- /dev/null
+++ b/temporary_resolver.js
@@ -0,0 +1,10 @@
+// temporary workaround until TS 4.5
+
+const resolver = require('enhanced-resolve').create.sync({
+ conditionNames: ['require'],
+ extensions: ['.js', '.json', '.node', '.ts']
+})
+
+module.exports = function (request, options) {
+ return resolver(options.basedir, request)
+} Your issue is also not a TS one, it's a jest one. "Jest is a delightful JavaScript Testing Framework with a focus on simplicity." 🤣 |
@panva Damn, sorry for wasting your time, had tried to be diligent. Thanks for working with me, that was helpful. |
I'm done waiting for these ecosystems to catch up. jose v4.x will be coming out today/tomorrow with only top level named exports that solve all these tools' problems. Including webpack@4 stuck create-react-app and out of the box jest |
Describe the bug
To Reproduce
Code to reproduce the behaviour: https://stackblitz.com/edit/react-ts-kkyw3y
Expected behaviour
Should import correctly with no errors
Environment:
jose
version: v3.11.6The text was updated successfully, but these errors were encountered: