Skip to content

Commit

Permalink
refactor: remove bundled TypeScript type defintions
Browse files Browse the repository at this point in the history
I'm moving types to DT so that only developers that use types incur the
added dependencies.

BREAKING CHANGE: TypeScript type definitions are no longer bundled with
the package, instead these will be re-published to DefinitelyTyped.
  • Loading branch information
panva committed Feb 21, 2021
1 parent 5c39a7f commit 3a6b671
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 2,230 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
run: npx panva/npm-install-retry
if: ${{ steps.node_modules.outputs.cache-hit != 'true' }}
- run: npm run lint
- run: npm run lint-ts

test:
name: Node Tests
Expand Down
6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,22 @@
"license": "MIT",
"author": "Filip Skokan <panva.ip@gmail.com>",
"files": [
"lib",
"types/index.d.ts"
"lib"
],
"funding": {
"url": "https://github.com/sponsors/panva"
},
"main": "lib/index.js",
"types": "types/index.d.ts",
"scripts": {
"ci": "node ./test/ci",
"coverage": "nyc node ./test/run",
"heroku-postbuild": "npm install mongodb@^3.0.0 openid-client@^4.0.0",
"lint": "eslint lib example certification test",
"lint-ts": "npx typescript@~3.6.0 --build types",
"lint-fix": "eslint lib example certification test --fix",
"test": "node ./test/run"
},
"dependencies": {
"@koa/cors": "^3.1.0",
"@types/koa": "^2.11.4",
"cacheable-lookup": "^6.0.0",
"debug": "^4.1.1",
"ejs": "^3.1.5",
Expand Down
Loading

3 comments on commit 3a6b671

@dotbenj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking on npm packages something like @types/oidc-provider and I cannot find any occurence of it. Do you know when it will be available ?

@panva
Copy link
Owner Author

@panva panva commented on 3a6b671 Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking on npm packages something like @types/oidc-provider and I cannot find any occurence of it. Do you know when it will be available ?

https://github.com/panva/node-oidc-provider/discussions/939

@dotbenj
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Please sign in to comment.