Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: avoid use of prototype attributes in keystore queries #660

Merged
merged 1 commit into from
Feb 7, 2024
Merged

refactor: avoid use of prototype attributes in keystore queries #660

merged 1 commit into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. Ignore __proto__ parameters for object hash equality. 

    When this library is run under environments which prohibit use of the
deprecated __proto__ getter/setter, it may cause a crash due to reading
from the __proto__ property. An example scenario is when the
`--disable-proto=throw` flag is used for NodeJS.

To disable consideration of the `prototype`, `__proto__`, and
`constructor` fields fields when hashing, the `respectType` flag can be
toggled off. This is not a problem for this library, as we are querying
only for the existence of a object created via an object literal, which
will have these properties all the same anyway.
    @pnappa
    pnappa committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    556f3ca View commit details
    Browse the repository at this point in the history