[stm32] actuators_pwm: replace set_servo_gpio with gpio_setup_pin_af #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AFIO remap in board file - gpio_setup_pin_af with uint32_t for af - remove PWM_SERVO_x_RCC
| @@ -51,7 +51,11 @@ extern void gpio_setup_input(uint32_t port, uint16_t gpios); | |||
| * Setup a gpio for input or output with alternate function. | |||
| * This is an STM32 specific helper funtion and should only be used in stm32 arch code. | |||
| */ | |||
| #if defined(STM32F1) | |||
| extern void gpio_setup_pin_af(uint32_t port, uint16_t pin, uint32_t af, bool_t is_output); | |||
| #else | |||
| extern void gpio_setup_pin_af(uint32_t port, uint16_t pin, uint8_t af, bool_t is_output); | |||
There was a problem hiding this comment.
and on F1 you pass a 32bit value... if that is what you meant.
There was a problem hiding this comment.
I also had problems with the gpio_get when compiling an F4.. that it was giving a warning sometimes.
There was a problem hiding this comment.
That is not related to this pull, but can you be a bit more specific? gpio_get is a function from libopencm3...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed to fix actuators_pwm on LisaL, please also test on LisaM and F4 boards...