Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails 7.2 #1488

Closed
rmatovu987 opened this issue Aug 20, 2024 · 7 comments
Closed

Add support for Rails 7.2 #1488

rmatovu987 opened this issue Aug 20, 2024 · 7 comments

Comments

@rmatovu987
Copy link

Thank you for your contribution!

Due to limited volunteers, issues that do not follow this template will be
closed without comment.

Is your feature suggestion related to a problem? Please describe.

There is a warning thrown in Rails 7.2 applications.
PaperTrail 15.1.0 is not compatible with ActiveRecord 7.2.0. We allow PT contributors to install incompatible versions of ActiveRecord, and this warning can be silenced with an environment variable, but this is a bad idea for normal use. Please install a compatible version of ActiveRecord instead (>= 6.1, < 7.2). Please see the discussion in paper_trail/compatibility.rb for details.

Describe the solution you'd like to build

Add support for Rails 7.2

Describe alternatives you've considered

N/A
@zameo94
Copy link

zameo94 commented Aug 21, 2024

@rmatovu987 Thanks for opening the ticket. Yes, we definitely need compatibility with Rail 7.2

@gurgelrenan
Copy link
Member

We have an P.R open and could be merged soon #1485

@xeron
Copy link

xeron commented Aug 24, 2024

Could someone please clarify – besides a warning about 7.2 are there any actual incompatibilities / issues?

@fatkodima
Copy link
Contributor

Could someone please clarify – besides a warning about 7.2 are there any actual incompatibilities / issues?

It works without problems if you don't have any existing paper_trail warnings, because in that case it will error out (but if you fix them, it will still work), see https://github.com/paper-trail-gem/paper_trail/pull/1485/files#diff-1f8592ba4c3060dd4ee3248e4104efc57d55d350f3234cf8562a55825b949dc0R161

@fatkodima fatkodima mentioned this issue Aug 26, 2024
Merged
10 tasks
@kapso
Copy link

kapso commented Sep 2, 2024

Any idea when Rails 7.2 support is going out? thanks.

@tarellel
Copy link

tarellel commented Sep 3, 2024 •
edited
Loading

@kapso

papertrail still works with 7.2, its just a warning you should be recieving.
If you're having issues, use the patched fork of the gem until it gets approved and merged into master.

#1485

jfi added a commit to tastybamboo/panda-cms that referenced this issue Sep 3, 2024
@jfi
Update gems for Rails 7.2
4e17bb3 
* Remove specific ref for paper_trail gem (paper-trail-gem/paper_trail#1488)
* Update awesome_nested_set to 3.7, compatible with Rails 7.2
* Update image_processing to 1.13
* Update tailwindcss-rails to 2.7
* Update view_component to 3.14
@jfi jfi mentioned this issue Sep 3, 2024
Merged
jfi added a commit to tastybamboo/panda-cms that referenced this issue Sep 3, 2024
@jfi
Update gems for Rails 7.2 (#3)
9740512 
### Background

Update dependencies for Rails 7.2, and other gem updates.

### Detail

This Pull Request:

* Removes specific ref for paper_trail gem (not required based on
discussion at
paper-trail-gem/paper_trail#1488)
* Updates awesome_nested_set to 3.7, compatible with Rails 7.2
* Updates image_processing to 1.13
* Updates tailwindcss-rails to 2.7
* Updates view_component to 3.14
@gurgelrenan
Copy link
Member

closed by #1485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tarellel @xeron @kapso @gurgelrenan @fatkodima @zameo94 @rmatovu987