Drop RequestStore in favour of ActiveSupport::CurrentAttributes
#1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
drop-request-store-for-active-support-current-attributes
branch
from
9b758ad to
1f76b9f
Compare
joshuay03
commented
Nov 16, 2023
| @@ -5,8 +5,6 @@ | |||
| RSpec.describe WidgetsController, type: :controller, versioning: true do | |||
| before { request.env["REMOTE_ADDR"] = "127.0.0.1" } | |||
|
|
|||
| after { RequestStore.store[:paper_trail] = nil } | |||
There was a problem hiding this comment.
Current attributes are automatically reset before each request so this is no longer necessary for the new implementation.
joshuay03
force-pushed
the
drop-request-store-for-active-support-current-attributes
branch
from
1f76b9f to
d363b54
Compare
joshuay03
force-pushed
the
drop-request-store-for-active-support-current-attributes
branch
5 times, most recently
from
9d977a8 to
8c58e67
Compare
|
CI is failing cause of reduced line coverage, but all my changes except for the new |
joshuay03
force-pushed
the
drop-request-store-for-active-support-current-attributes
branch
from
8c58e67 to
c43279b
Compare
|
This PR has been automatically marked as stale due to inactivity. |
|
@jaredbeck would you mind taking a look at this? 🙏 |
|
Re-opening because it was closed as stale but I do think its a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.
Fixes #1444
I wonder if there are any performance benefits here, I'm happy to run some benchmarks if it's a valid concern.