refactor!: switch from parking_lot to std::sync #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
force-pushed
the
std-locks
branch
2 times, most recently
from
92a7c77 to
3d71461
Compare
tiagolobocastro
force-pushed
the
std-locks
branch
from
3d71461 to
78b4bd8
Compare
As pointed out in 438 the mutex performance between parking_lot should not adversely affect paperclip. Also remove the mutexes altogether from the ApiError. Unfortunately this is indeed a breaking change! Resolves: #438 Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
std-locks
branch
from
78b4bd8 to
1bd05f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #438 the mutex performance between parking_lot should not adversely affect paperclip.
Also remove the mutexes altogether from the ApiError.
Unfortunately this is indeed a breaking change!
Resolves: #438
Signed-off-by: Tiago Castro tiagolobocastro@gmail.com