pretty good tests

papermerge/search/routers/search.py

@@ -13,15 +13,15 @@
     tags=["search"]
 )
 
-engine = create_engine(settings.SEARCH_URL)
-
 
 @router.get("/")
 def search(
     q: str,
     user: User = Depends(current_user)
 ) -> List[IndexEntity]:
+    engine = create_engine(settings.SEARCH_URL)
     session = Session(engine)
+
     sq = Search(IndexEntity).query(q)
 
     results: List[IndexEntity] = session.exec(sq)

tests/conftest.py

@@ -1,6 +1,9 @@
 import pytest
+from django.conf import settings
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
+from salinic import Session, create_engine
+from salinic.engine import AccessMode
 
 from papermerge.core.models import User
 from papermerge.core.routers import register_routers as reg_core_routers
@@ -46,3 +49,10 @@ def auth_api_client(user: User):
         test_client=test_client,
         user=user
     )
+
+
+@pytest.fixture()
+def session(tmp_path) -> Session:
+    engine = create_engine(settings.SEARCH_URL, mode=AccessMode.RW)
+
+    return Session(engine)

tests/search/test_search.py

@@ -1,9 +1,49 @@
 import pytest
-from fastapi.testclient import TestClient
+from salinic.session import Session
 
+from papermerge.core.models import User
+from papermerge.search.schema import IndexEntity
+from papermerge.test.types import AuthTestClient
+
+
+@pytest.mark.django_db(transaction=True)
+def test_basic(
+    auth_api_client: AuthTestClient,
+    session: Session
+):
+    """Checks that search returns only documents belonging to current user """
+    current_user: User = auth_api_client.user
+
+    # document belong to current user
+    doc_1 = IndexEntity(
+        id='one',
+        document_id='doc_1',
+        title='Anmeldung',
+        user_id=str(current_user.id),
+        parent_id='parent_id',
+        entity_type='page',
+        breadcrumb=[('home', 'home_id')]
+    )
+    session.add(doc_1)
+
+    # document does not belong to current user
+    doc_2 = IndexEntity(
+        id='two',
+        document_id='doc_2',
+        title='Anmeldung',
+        user_id='i-belong-to-other-user',
+        parent_id='parent_id_2',
+        entity_type='page',
+        breadcrumb=[('home', 'home_id')]
+    )
+    session.add(doc_2)
+
+    response = auth_api_client.get("/search?q=Anmeldung")
 
-@pytest.mark.django_db
-def test_basic(auth_api_client: TestClient):
-    response = auth_api_client.get("/search?q=one")
     assert response.status_code == 200
-    assert response.json() == {"msg": "Hello World"}
+
+    returned_models = response.json()
+    assert len(returned_models) == 1
+
+    returned_model = returned_models[0]
+    assert returned_model['id'] == doc_1.model_dump()['id']