Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action to rebase release PR to develop #767

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Add Action to rebase release PR to develop #767

merged 3 commits into from
Feb 2, 2024

Conversation

Thesola10
Copy link
Collaborator

This (as of yet untested) GitHub action will automatically detect PRs created against release and redirect them to develop (and leave a nice comment).

This only applies on creation, so PRs can still be rebased to release if needs be.

@Thesola10 Thesola10 changed the base branch from release to develop January 30, 2024 11:08
@Thesola10
Copy link
Collaborator Author

Thesola10 commented Jan 30, 2024

how nice, the PR is testing itself :3

... okay why is it taking so long to get a runner? @jtaala you think public runners are disabled in the PaperWM org?

@Thesola10 Thesola10 requested a review from jtaala January 30, 2024 11:13
@Thesola10 Thesola10 added documentation Missing or inaccurate docs/onboarding project support Issues related to supporting or improving the project labels Jan 30, 2024
@jtaala
Copy link
Collaborator

jtaala commented Jan 30, 2024

how nice, the PR is testing itself :3

... okay why is it taking so long to get a runner? @jtaala you think public runners are disabled in the PaperWM org?

I don't believe so. I've checked settings and actions settings allows all actions and resusable workflows. Says no runners are configured though.

@jtaala
Copy link
Collaborator

jtaala commented Jan 30, 2024

Looks like only option for runners is creating a self-hosted runner.

I'm not familiar with github runners though so not sure.

@jtaala
Copy link
Collaborator

jtaala commented Jan 30, 2024

There doesn't seem to be an option to add a github-hosted runner, maybe that only available in github enterprise?... or maybe it is blocked at the org level (note: I don't have org perms).

@Thesola10
Copy link
Collaborator Author

Thesola10 commented Jan 30, 2024

There doesn't seem to be an option to add a github-hosted runner, maybe that only available in github enterprise?... or maybe it is blocked at the org level (note: I don't have org perms).

Likely the latter. I control a solo org and I can enable GitHub runners on it. We might need @hedning for this one.

@jtaala
Copy link
Collaborator

jtaala commented Jan 30, 2024

We might need @hedning for this one.

Ouch, that may end up being a showstopper on this one then... unfortunately, we haven't heard from @hedning in a number of years :-(

@Thesola10
Copy link
Collaborator Author

Thesola10 commented Jan 30, 2024

Maybe @olejorgenb can help? They're also an org member and seem more active on their GitHub.

@Thesola10 Thesola10 requested a review from olejorgenb January 30, 2024 13:51
@jtaala
Copy link
Collaborator

jtaala commented Jan 30, 2024

Maybe @olejorgenb can help? They're also an org member and seem more active on their GitHub.

Well, we've pinged @olejorgenb in this chat - so he can respond if he's able to. I did get a response from @olejorgenb back in 2022, so it's possible.

Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Once we can run things (runner) in PaperWM can merge this in.

@olejorgenb
Copy link
Member

I can help setting things up if there's missing access, but I'm not familiar with github runners, and don't have time to figure out the exact steps. To me it seems like a standard runner should be available though.

image
image
image
image

@Thesola10
Copy link
Collaborator Author

Thanks for checking @olejorgenb, maybe GitHub was just having a bad day ¯⁠\⁠_⁠(⁠ツ⁠)⁠_⁠/⁠¯

@Thesola10 Thesola10 changed the base branch from develop to release February 2, 2024 18:12
@Thesola10 Thesola10 marked this pull request as draft February 2, 2024 18:12
@Thesola10 Thesola10 marked this pull request as ready for review February 2, 2024 18:13
@Thesola10 Thesola10 marked this pull request as draft February 2, 2024 18:13
Copy link

github-actions bot commented Feb 2, 2024

Thanks for your contribution! We don't accept pull requests to the release branch. I have rebased your pull request onto develop, check for any conflicts.

@github-actions github-actions bot changed the base branch from release to develop February 2, 2024 18:13
@Thesola10 Thesola10 marked this pull request as ready for review February 2, 2024 18:14
@Thesola10
Copy link
Collaborator Author

oh, finally. @jtaala if you have perms could you delete #772 and #773? sorry for the inconvenience!

@Thesola10 Thesola10 requested review from jtaala and removed request for olejorgenb February 2, 2024 18:16
@jtaala
Copy link
Collaborator

jtaala commented Feb 2, 2024

I can help setting things up if there's missing access, but I'm not familiar with github runners, and don't have time to figure out the exact steps. To me it seems like a standard runner should be available though.

Thanks @olejorgenb! Hope things are going well. Looks like it's it's working now.

@jtaala jtaala merged commit 32e6bd0 into develop Feb 2, 2024
@jtaala jtaala deleted the action-rebase branch February 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Missing or inaccurate docs/onboarding project support Issues related to supporting or improving the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants