-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added switch-global-* actions #775
Conversation
Thanks for the PR @dawsers! Looks okay to me. I'll give this a test soon. Note: I changed the branch to |
@kassick looks like the |
linting standards.
Hey @dawsers. Looks good. I've just implemented fluid minimap/navigation across monitors (i.e. the minimap jumps to the other monitor - feels better and more natural here). Also applied paperwm linter (which just fixed up some things re style/formatting). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and feels good. I like this approach - glad you thought of it!
@dawsers - see #723 (comment) Given your contribution, if you have a donation link to accept donations (e.g. buymeacoffee.com etc) let me know and I'll add for the next release. |
Thank you so much for cleaning it up and adding it! There is no need to add me to donations or anything. I have been using PaperWM just for a few days (moved from QTile), and I really like it, so I am very grateful to you guys. I guess this PR can be closed. |
I'll merge this into |
may have something to do with permissions somehow? maybe due to committer not being a trusted contributor |
This pull request is to add four new actions that complement
switch-right
,switch-left
,switch-up
andswitch-down
with global versions that change window regardless of monitor boundaries. This means the action will not respect the current monitor boundaries and will select a window on the adjacent monitor if the previous selection was at a boundary. For example,switch-global-right
when the selected window is the rightmost of a space will move to the monitor on the right and select the first window. While within monitor boundaries, the behavior is exactly the same asswitch-*
.<Super><Shift><right/left/up/down>
, which preserves the last selected window on each space when moving back and forth, whileswitch-global-*
actions don't (they move to the "closest" window).switch-*
with the actionsswitch-global-*
, but by default, the change doesn't do anything.The pull request is backwards compatible, transparent, and needs the user to enable the behavior knowingly; it doesn't add any key bindings by default.