Merge branch 'main' into pool-transaction-generics

paradigmxyz · Sep 25, 2024 · 36bbddd · 36bbddd
2 parents 039ecae + 89b6ad2
commit 36bbddd
Show file tree

Hide file tree

Showing 243 changed files with 2,578 additions and 2,784 deletions.
diff --git a/.github/assets/hive/expected_failures.yaml b/.github/assets/hive/expected_failures.yaml
@@ -19,7 +19,6 @@ rpc-compat:
   - eth_getBlockByNumber/get-genesis (reth)
   - eth_getBlockByNumber/get-latest (reth)
   - eth_getBlockByNumber/get-safe (reth)
-  - eth_sendRawTransaction/send-blob-tx (reth)
 
 # https://github.com/paradigmxyz/reth/issues/8732
 engine-withdrawals:

diff --git a/.github/assets/hive/expected_failures_experimental.yaml b/.github/assets/hive/expected_failures_experimental.yaml
@@ -19,7 +19,6 @@ rpc-compat:
   - eth_getBlockByNumber/get-genesis (reth)
   - eth_getBlockByNumber/get-latest (reth)
   - eth_getBlockByNumber/get-safe (reth)
-  - eth_sendRawTransaction/send-blob-tx (reth)
 
 # https://github.com/paradigmxyz/reth/issues/8732
 engine-withdrawals:

diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -1,4 +1,4 @@
-# Runs benchmarks.
+# Runs benchmarks on serialization/deserialization of storage values and keys.
 
 on:
   pull_request:
@@ -48,13 +48,16 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.base_ref || 'main' }}
+      # On `main` branch, generates test vectors and serializes them to disk using `serde-json`.
       - name: Generate test vectors
         run: cargo run --bin reth --features dev -- test-vectors tables
+      # Runs iai and stores `main` baseline report for comparison later on $BASELINE.
       - name: Save baseline
         run: cargo bench -p reth-db --bench iai --profile profiling --features test-utils -- --save-baseline=$BASELINE
       - name: Checkout PR
         uses: actions/checkout@v4
         with:
           clean: false
+      # Runs iai on incoming merge using previously generated test-vectors and compares the report against `main` report.
       - name: Compare PR benchmarks
         run: cargo bench -p reth-db --bench iai --profile profiling --features test-utils -- --baseline=$BASELINE