Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BlockchainProvider2 receipt methods aware of in-memory state #10182

Closed
Tracked by #10186
Rjected opened this issue Aug 7, 2024 · 0 comments · Fixed by #11414
Closed
Tracked by #10186

Make BlockchainProvider2 receipt methods aware of in-memory state #10182

Rjected opened this issue Aug 7, 2024 · 0 comments · Fixed by #11414
Assignees
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior

Comments

@Rjected
Copy link
Member

Rjected commented Aug 7, 2024

Similar to #10181, the following methods only fetch from the database and do not check in-memory state:

fn receipts_by_tx_range(
&self,
range: impl RangeBounds<TxNumber>,
) -> ProviderResult<Vec<Receipt>> {
self.database.receipts_by_tx_range(range)
}

fn receipt(&self, id: TxNumber) -> ProviderResult<Option<Receipt>> {
self.database.receipt(id)
}

These should also be updated to be aware of the current in-memory canonical state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants