feat(provider): receipt and transaction by id in BlockchainProvider2
#10281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-blockchain-tree
shekhirin
force-pushed
the
alexey/blockchain-provider-receipt-id
branch
from
3848141 to
270c2eb
Compare
shekhirin
force-pushed
the
alexey/blockchain-provider-receipt-id
branch
from
270c2eb to
c20bb0e
Compare
shekhirin
changed the title
shekhirin
changed the title
BlockchainProvider2
shekhirin
commented
Aug 13, 2024
| fn block_number_by_tx_id( | ||
| &self, | ||
| id: TxNumber, | ||
| ) -> ProviderResult<Option<(BlockNumber, usize, bool)>> { |
There was a problem hiding this comment.
maybe an enum is better?
There was a problem hiding this comment.
When it is in memory, could we just return the entire BlockState as well as the tx index here, rather than just the block number? That way the calling methods do not need to fetch the state again
There was a problem hiding this comment.
yeah right, fixed
Rjected
reviewed
Aug 13, 2024
| fn block_number_by_tx_id( | ||
| &self, | ||
| id: TxNumber, | ||
| ) -> ProviderResult<Option<(BlockNumber, usize, bool)>> { |
There was a problem hiding this comment.
When it is in memory, could we just return the entire BlockState as well as the tx index here, rather than just the block number? That way the calling methods do not need to fetch the state again
joshieDo
reviewed
Aug 13, 2024
shekhirin
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10182 and #10181, but only parts with point queries