Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more RPC module tests #1224

Closed
mattsse opened this issue Feb 8, 2023 · 3 comments · Fixed by #1288
Closed

Add more RPC module tests #1224

mattsse opened this issue Feb 8, 2023 · 3 comments · Fixed by #1288
Assignees
@ensi321
Labels
A-rpc Related to the RPC implementation C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 8, 2023

Describe the feature

With #1222
we have helper functions for launching RPC server bindings via the Client traits

we need to cover every available module

TODO

  • replicate the test_call_<module>_functions_<transport> functions for other modules

some of them (like tracing/debug) are not implemented yet, responses should be checked for the corresponding rpc error instead.

Additional context

No response
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation C-test A change that impacts how or what we test labels Feb 8, 2023
@mattsse mattsse mentioned this issue Feb 8, 2023
Closed
@ensi321
Copy link
Contributor

ensi321 commented Feb 8, 2023 •
edited
Loading

I would like to take this one on

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 8, 2023

@literallymarvellous did you start working on this or is this still up for grabs?

@literallymarvellous
Copy link
Contributor

No not yet, he can take it.

@ensi321 ensi321 mentioned this issue Feb 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ensi321 ensi321

Labels
A-rpc Related to the RPC implementation C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test(rpc): Test support for different api modules ensi321/reth
3 participants
@ensi321 @mattsse @literallymarvellous