Test(rpc): Test support for different api modules #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 76.90% 77.20% +0.30%
==========================================
Files 340 348 +8
Lines 37878 38598 +720
==========================================
+ Hits 29131 29801 +670
- Misses 8747 8797 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattsse
added
A-rpc
mattsse
requested changes
Feb 11, 2023
Comment on lines
76
to
81
| // EthApiClient::send_transaction(client).await.err().unwrap())); | ||
| // EthApiClient::send_raw_transaction(client).await.err().unwrap())); | ||
| // EthApiClient::sign(client).await.err().unwrap())); | ||
| // EthApiClient::sign_transaction(client).await.err().unwrap())); | ||
| // EthApiClient::sign_typed_data(client).await.err().unwrap())); | ||
| // EthApiClient::get_proof(client).await.err().unwrap())); |
There was a problem hiding this comment.
why are they currently commented?
There was a problem hiding this comment.
@mattsse maybe you were looking at an older version of the PR?
grantkee
pushed a commit
to layer-g/reth
that referenced
this pull request
Feb 14, 2023
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1224