Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine API Changes for Shanghai #1297

Closed
Tracked by #1295
gakonst opened this issue Feb 12, 2023 · 0 comments · Fixed by #1445
Closed
Tracked by #1295

Engine API Changes for Shanghai #1297

gakonst opened this issue Feb 12, 2023 · 0 comments · Fixed by #1445
Assignees
@rkrasiuk
Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-enhancement New feature or request

Comments

@gakonst
Copy link
Member

gakonst commented Feb 12, 2023 •
edited by rkrasiuk
Loading

Describe the feature

Introduced here in the specs by @ralexstokes.

  • Execution APIs Spec.
  • Introduces V2 variants for the payload types (w/ the withdrawals type), and engine_getPayloadBodiesByHashV1 & engine_getPayloadBodiesByRangeV1 so the CL can batch query payloads.
  • Note we already have Option<Withdrawal> in a couple places, this should be replaced with Vec<Withdrawal>

Related
@gakonst gakonst added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 12, 2023
@gakonst gakonst mentioned this issue Feb 12, 2023
Closed
@gakonst gakonst changed the title Tracking: Engine API Changes for Shanghai Engine API Changes for Shanghai Feb 12, 2023
@gakonst gakonst mentioned this issue Feb 12, 2023
Closed
@onbjerg onbjerg added A-rpc Related to the RPC implementation A-consensus Related to the consensus engine and removed S-needs-triage This issue needs to be labelled labels Feb 14, 2023
@onbjerg onbjerg moved this from Todo to In Progress in Reth Tracker Feb 14, 2023
This was referenced Feb 16, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkrasiuk rkrasiuk

Labels
A-consensus Related to the consensus engine A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(engine-api): Shanghai support paradigmxyz/reth
3 participants
@onbjerg @gakonst @rkrasiuk