Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockBody::transaction_count helper function #13639

Closed
mattsse opened this issue Jan 3, 2025 · 4 comments · Fixed by #13660
Closed

Add BlockBody::transaction_count helper function #13639

mattsse opened this issue Jan 3, 2025 · 4 comments · Fixed by #13660
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 3, 2025

Describe the feature

ref #13626

we often use:

Image

it be nicer to have this

TODO

  • introduce these two functions (trait + native on SealedBlock)
  • simplify .body().transactions().len() with .transaction_count

cc @Nanle100

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@frankudoags
Copy link
Contributor

Can I take this?

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 3, 2025

assigned, ty

@mymiracle0118
Copy link

I’d love to work on this task.

@aidenwong812
Copy link

Could I try solving this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
4 participants