Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl "Add BlockBody::transaction_count helper function" #13643

Closed
wants to merge 0 commits into from
Closed

feat: Impl "Add BlockBody::transaction_count helper function" #13643

wants to merge 0 commits into from

Conversation

frankudoags
Copy link
Contributor

Closes #13639

PR Checklist:

  • introduce these two functions (trait + native on SealedBlock)
  • simplify .body().transactions().len() with .transaction_count

mattsse
mattsse approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mattsse
Copy link
Collaborator

mattsse commented Jan 4, 2025

ty!
just needs cargo +nightly fmt

please don't open from main branch because edits by maintainer are not allowed there

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Jan 4, 2025
@frankudoags
Copy link
Contributor Author

ty! just needs cargo +nightly fmt

done

please don't open from main branch because edits by maintainer are not allowed there

Rookie mistake, duly noted ty

@frankudoags frankudoags closed this Jan 5, 2025
@frankudoags
Copy link
Contributor Author

Closed in favour of #13660 to allow any necessary edits by maintainers while reviewing.

cc @mattsse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita

@joshieDo joshieDo Awaiting requested review from joshieDo

@shekhirin shekhirin Awaiting requested review from shekhirin

@onbjerg onbjerg Awaiting requested review from onbjerg

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@Rjected Rjected Awaiting requested review from Rjected

@klkvr klkvr Awaiting requested review from klkvr

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BlockBody::transaction_count helper function
2 participants
@frankudoags @mattsse