Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill missing Tx receipt info #1922

Closed
mattsse opened this issue Mar 23, 2023 · 3 comments · Fixed by #1931
Closed

Fill missing Tx receipt info #1922

mattsse opened this issue Mar 23, 2023 · 3 comments · Fixed by #1931
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 23, 2023

Describe the feature

#1919 added transaction receipt.

some things are missing or incorrect atm:

  • gas_used this can be calculated by comparing the cumulative_gas_used of transaction
  • remaining log fields still need to be filled
  • state root needs to be set (unsure how)

cc @chirag-bgh

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 23, 2023
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled C-enhancement New feature or request labels Mar 23, 2023
@chirag-bgh
Copy link
Contributor

on it!

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 23, 2023

sick!
I'll merge #1919 in the meantime

@mattsse
Copy link
Collaborator Author

mattsse commented Mar 23, 2023 •
edited
Loading

@chirag-bgh also, I do believe the

reth/crates/rpc/rpc-types/src/eth/log.rs

Lines 24 to 25 in b443917

/// Log Index in Transaction
pub transaction_log_index: Option<U256>,

is not actually part of the spec, at least not used by geth if I read that correctly:

https://github.com/ethereum/go-ethereum/blob/ee530c0d5aa70d2c00ab5691a89ab431b73f8165/core/types/log.go#L31-L31

https://ethereum.org/en/developers/docs/apis/json-rpc/

@chirag-bgh chirag-bgh mentioned this issue Mar 23, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add missing Tx receipt info chirag-bgh/reth
2 participants
@mattsse @chirag-bgh