-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add transaction_receipt #1919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just smol refactor needed which also tests the fields are set correctly
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1919 +/- ##
===========================================
- Coverage 72.99% 17.22% -55.77%
===========================================
Files 418 417 -1
Lines 51345 51376 +31
===========================================
- Hits 37479 8851 -28628
- Misses 13866 42525 +28659
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 301 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty.
I made few changes.
Some things are missing but I'll create a separate issue to follow up on this.
Closes #1883