Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction_receipt #1919

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Conversation

chirag-bgh
Copy link
Contributor

Closes #1883

@chirag-bgh chirag-bgh marked this pull request as ready for review March 22, 2023 21:39
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just smol refactor needed which also tests the fields are set correctly

crates/rpc/rpc/src/eth/api/server.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #1919 (e0d79e3) into main (2bc4da5) will decrease coverage by 55.77%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main    #1919       +/-   ##
===========================================
- Coverage   72.99%   17.22%   -55.77%     
===========================================
  Files         418      417        -1     
  Lines       51345    51376       +31     
===========================================
- Hits        37479     8851    -28628     
- Misses      13866    42525    +28659     
Flag Coverage Δ
integration-tests 17.22% <0.00%> (-2.38%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-types/src/eth/log.rs 0.00% <0.00%> (-100.00%) ⬇️
...rates/rpc/rpc-types/src/eth/transaction/receipt.rs 0.00% <ø> (ø)
crates/rpc/rpc/src/eth/api/server.rs 62.39% <0.00%> (-36.18%) ⬇️
crates/rpc/rpc/src/eth/api/transactions.rs 13.84% <0.00%> (-16.77%) ⬇️

... and 301 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty.

I made few changes.

Some things are missing but I'll create a separate issue to follow up on this.

@mattsse mattsse merged commit aaa99f6 into paradigmxyz:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement eth_getTransactionReceipt
5 participants