Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make EngineApiRequestHandler generic over request #10147

Merged
merged 3 commits into from
Aug 6, 2024
Merged

feat: make EngineApiRequestHandler generic over request #10147

merged 3 commits into from
Aug 6, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 6, 2024 •
edited
Loading

towards #10097

this makes it possible to have an EngineApiRequestHandler that supports a superset of request.

for example additional commands, such as inserting a custom block

@mattsse mattsse added the C-enhancement New feature or request label Aug 6, 2024
Rjected
Rjected approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, yeah Into should work

@mattsse mattsse enabled auto-merge August 6, 2024 21:16
@mattsse mattsse added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit f8104cc Aug 6, 2024
34 checks passed
@mattsse mattsse deleted the matt/add-request-generic branch August 6, 2024 21:40
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@mattsse @martinezjorge
feat: make EngineApiRequestHandler generic over request (paradigmxyz#…
5a8d981 
…10147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected