-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(provider): RequestsProvider
of BlockchainProvider2
#10356
Conversation
…vider-requests-provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about otherwise making new function for when new param is used? seems like most calls take None
for that param, so mainly not needed. this can be done easily by adding a third function, with the body of the current function, so that the function body of the original function, can just call my_func(arg1, arg2, .., None)
…vider-requests-provider
yeah makes sense, agreed. Maybe we can just pass a struct instead of fields one by one, and the struct will have a |
hmm, actually we have just one optional field now which is |
Closes #10343
The change turned out to be more invasive than expected because I added an argument for randomly generating requests into
random_block
andrandom_block_range
.