refactor: random_block(s) function #10499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-debt
jenpaff
changed the title
jenpaff
force-pushed
the
jenpaff/refactor-random_blocks-function
branch
from
92c82c5 to
33110dc
Compare
jenpaff
changed the title
shekhirin
reviewed
Aug 26, 2024
jenpaff
force-pushed
the
jenpaff/refactor-random_blocks-function
branch
2 times, most recently
from
7d44bb4 to
7ba1c18
Compare
jenpaff
force-pushed
the
jenpaff/refactor-random_blocks-function
branch
from
7ba1c18 to
2ff861c
Compare
shekhirin
reviewed
Aug 26, 2024
| let blocks = random_block_range( | ||
| &mut rng, | ||
| 1..=10, | ||
| BlockParams { parent: Some(B256::ZERO), tx_count: Some(0..2), ..Default::default() }, |
There was a problem hiding this comment.
hmm why is this change from 2..3 to 0..2 required?
There was a problem hiding this comment.
This is incorrect, but i think the test is rightfully failing- will fix in a bit, just debugging 2 other tests
jenpaff
commented
Aug 26, 2024
| @@ -2348,8 +2354,7 @@ mod tests { | |||
| &mut rng, | |||
| TEST_BLOCKS_COUNT, | |||
| TEST_BLOCKS_COUNT, | |||
| None, | |||
| None, | |||
| BlockParams::default(), | |||
There was a problem hiding this comment.
@shekhirin seems like the test_receipt_provider_* tests are failing on here. it seems to me like they are passing on main cos both lists are empty, debugging..
|
superseded by #10563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10457
Implementation Details:
BlockParamsused to pass arguments for random block generationrandom_block(generates one block) +random_block_rangefunctions to use new struct (could've been done separately, but decided to combine both since they were so similar)