fix: revert header error message change #10866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Sep 12, 2024
onbjerg
force-pushed
the
onbjerg/header-not-found-err
branch
from
1c172ab to
6dbf37c
Compare
onbjerg
force-pushed
the
onbjerg/header-not-found-err
branch
from
6dbf37c to
e11f0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently op-reth and alphanet are not able to communicate properly with op-node because we changed the error message for missing blocks/headers, which op-node does a string match on to decide how to fetch the header otherwise.
This PR reverts that change temporarily until ethereum-optimism/optimism#11759 is merged, which will unblock alphanet progress
Supersedes #10864