Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the nightly version to latest #10905

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you revert everything but this file to main? then we can merge this. other conflicts have been fixed in smaller prs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to open a new PR given several commits and conflicts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye, probably right, this lint issue was a big pain for everyone, so had to push it through asap in many prs with smaller scope (easier to review/merge conflicts don't accumulate), thanks nonetheless

Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-09-09
toolchain: nightly
components: clippy
- uses: Swatinem/rust-cache@v2
with:
Expand Down
1 change: 1 addition & 0 deletions crates/chain-state/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use crate::{
in_memory::ExecutedBlock, CanonStateNotification, CanonStateNotifications,
CanonStateSubscriptions,
Expand Down
1 change: 1 addition & 0 deletions crates/consensus/beacon/src/engine/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use crate::{
engine::hooks::PruneHook, hooks::EngineHooks, BeaconConsensusEngine,
BeaconConsensusEngineError, BeaconConsensusEngineHandle, BeaconForkChoiceUpdateError,
Expand Down
1 change: 1 addition & 0 deletions crates/engine/tree/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use reth_chainspec::ChainSpec;
use reth_network_p2p::test_utils::TestFullBlockClient;
use reth_primitives::{BlockBody, SealedHeader, B256};
Expand Down
1 change: 1 addition & 0 deletions crates/ethereum/node/tests/e2e/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
mod blobs;
mod dev;
mod eth;
Expand Down
1 change: 1 addition & 0 deletions crates/ethereum/node/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
mod builder;
mod exex;

Expand Down
2 changes: 1 addition & 1 deletion crates/evm/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Helpers for testing.

#![allow(missing_docs)]
use crate::execute::{
BatchExecutor, BlockExecutionInput, BlockExecutionOutput, BlockExecutorProvider, Executor,
};
Expand Down
1 change: 1 addition & 0 deletions crates/exex/exex/src/backfill/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use std::sync::Arc;

use eyre::OptionExt;
Expand Down
2 changes: 1 addition & 1 deletion crates/metrics/metrics-derive/tests/metrics.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![allow(missing_docs)]
#![expect(missing_docs)]
use metrics::{
Counter, Gauge, Histogram, Key, KeyName, Label, Metadata, Recorder, SharedString, Unit,
};
Expand Down
2 changes: 1 addition & 1 deletion crates/net/discv4/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Mock discovery support

#![allow(missing_docs)]
use crate::{
proto::{FindNode, Message, Neighbours, NodeEndpoint, Packet, Ping, Pong},
receive_loop, send_loop, Discv4, Discv4Config, Discv4Service, EgressSender, IngressEvent,
Expand Down
2 changes: 1 addition & 1 deletion crates/net/downloaders/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Test helper impls.

#![allow(missing_docs)]
#![allow(dead_code)]

use crate::{bodies::test_utils::create_raw_bodies, file_codec::BlockFileCodec};
Expand Down
2 changes: 1 addition & 1 deletion crates/net/eth-wire/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Utilities for testing p2p protocol.

#![allow(missing_docs)]
use crate::{
hello::DEFAULT_TCP_PORT, EthVersion, HelloMessageWithProtocols, P2PStream, ProtocolVersion,
Status, UnauthedP2PStream,
Expand Down
2 changes: 1 addition & 1 deletion crates/net/eth-wire/tests/fuzz_roundtrip.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Round-trip encoding fuzzing for the `eth-wire` crate.

#![allow(missing_docs)]
use alloy_rlp::{Decodable, Encodable};
use serde::Serialize;
use std::fmt::Debug;
Expand Down
2 changes: 1 addition & 1 deletion crates/net/eth-wire/tests/new_block.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Decoding tests for [`NewBlock`]

#![allow(missing_docs)]
use alloy_rlp::Decodable;
use reth_eth_wire::NewBlock;
use reth_primitives::hex;
Expand Down
2 changes: 1 addition & 1 deletion crates/net/eth-wire/tests/new_pooled_transactions.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Decoding tests for [`NewPooledTransactions`]

#![allow(missing_docs)]
use alloy_rlp::Decodable;
use reth_eth_wire::NewPooledTransactionHashes66;
use reth_primitives::hex;
Expand Down
2 changes: 1 addition & 1 deletion crates/net/eth-wire/tests/pooled_transactions.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Decoding tests for [`PooledTransactions`]

#![allow(missing_docs)]
use alloy_rlp::{Decodable, Encodable};
use reth_eth_wire::{EthVersion, PooledTransactions, ProtocolMessage};
use reth_primitives::{hex, PooledTransactionsElement};
Expand Down
2 changes: 1 addition & 1 deletion crates/net/network-api/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! API for integration testing network components.

#![allow(missing_docs)]
pub mod peers_manager;

pub use peers_manager::{PeerCommand, PeersHandle, PeersHandleProvider};
2 changes: 1 addition & 1 deletion crates/net/network/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Common helpers for network testing.

#![allow(missing_docs)]
mod init;
mod testnet;

Expand Down
1 change: 0 additions & 1 deletion crates/net/network/tests/it/connect.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//! Connection tests

use std::{collections::HashSet, net::SocketAddr, time::Duration};

use alloy_node_bindings::Geth;
Expand Down
1 change: 1 addition & 0 deletions crates/net/p2p/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
mod bodies;
mod full_block;
mod headers;
Expand Down
1 change: 1 addition & 0 deletions crates/optimism/node/tests/e2e/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
#[cfg(feature = "optimism")]
mod p2p;

Expand Down
1 change: 1 addition & 0 deletions crates/optimism/node/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
#[cfg(feature = "optimism")]
mod builder;

Expand Down
2 changes: 1 addition & 1 deletion crates/payload/builder/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Utils for testing purposes.

#![allow(missing_docs)]
use crate::{
error::PayloadBuilderError, traits::KeepPayloadJobAlive, EthBuiltPayload,
EthPayloadBuilderAttributes, PayloadBuilderHandle, PayloadBuilderService, PayloadJob,
Expand Down
2 changes: 1 addition & 1 deletion crates/primitives-traits/src/header/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Test utilities to generate random valid headers.

#![allow(missing_docs)]
use crate::Header;
use alloy_primitives::B256;
use proptest::{arbitrary::any, prop_compose};
Expand Down
1 change: 1 addition & 0 deletions crates/revm/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use crate::precompile::HashMap;
use alloc::vec::Vec;
use reth_primitives::{
Expand Down
1 change: 1 addition & 0 deletions crates/rpc/rpc-builder/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
mod auth;
mod http;
mod middleware;
Expand Down
1 change: 1 addition & 0 deletions crates/rpc/rpc-engine-api/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
mod payload;

const fn main() {}
1 change: 1 addition & 0 deletions crates/stages/stages/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use reth_stages_api::StageId;

#[cfg(test)]
Expand Down
1 change: 1 addition & 0 deletions crates/storage/provider/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use crate::{providers::StaticFileProvider, HashingWriter, ProviderFactory, TrieWriter};
use reth_chainspec::{ChainSpec, MAINNET};
use reth_db::{
Expand Down
1 change: 1 addition & 0 deletions crates/tracing/src/test_tracer.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use tracing_appender::non_blocking::WorkerGuard;
use tracing_subscriber::EnvFilter;

Expand Down
2 changes: 1 addition & 1 deletion crates/transaction-pool/src/test_utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! Internal helpers for testing.

#![allow(missing_docs)]
use crate::{blobstore::InMemoryBlobStore, noop::MockTransactionValidator, Pool, PoolConfig};
use std::ops::Deref;

Expand Down
2 changes: 1 addition & 1 deletion crates/transaction-pool/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! transaction-pool integration tests

#![allow(missing_docs)]
#[cfg(feature = "test-utils")]
mod blobs;
#[cfg(feature = "test-utils")]
Expand Down
1 change: 1 addition & 0 deletions crates/trie/db/tests/fuzz_in_memory_nodes.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use proptest::prelude::*;
use reth_db::{
cursor::{DbCursorRO, DbCursorRW, DbDupCursorRW},
Expand Down
1 change: 1 addition & 0 deletions crates/trie/db/tests/post_state.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use proptest::prelude::*;
use proptest_arbitrary_interop::arb;
use reth_db::{tables, test_utils::create_test_rw_db};
Expand Down
1 change: 1 addition & 0 deletions crates/trie/db/tests/proof.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use reth_chainspec::{Chain, ChainSpec, HOLESKY, MAINNET};
use reth_primitives::{constants::EMPTY_ROOT_HASH, keccak256, Account, Address, Bytes, B256, U256};
use reth_provider::test_utils::{create_test_provider_factory, insert_genesis};
Expand Down
1 change: 1 addition & 0 deletions crates/trie/db/tests/trie.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use proptest::{prelude::ProptestConfig, proptest};
use proptest_arbitrary_interop::arb;
use reth_db::{tables, test_utils::TempDatabase, DatabaseEnv};
Expand Down
1 change: 1 addition & 0 deletions crates/trie/db/tests/walker.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use reth_db::tables;
use reth_db_api::{cursor::DbCursorRW, transaction::DbTxMut};
use reth_primitives::B256;
Expand Down
1 change: 1 addition & 0 deletions crates/trie/trie/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#![allow(missing_docs)]
use alloy_primitives::{Address, B256, U256};
use alloy_rlp::encode_fixed_size;
use reth_primitives::Account;
Expand Down
1 change: 1 addition & 0 deletions testing/ef-tests/tests/tests.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![cfg(feature = "ef-tests")]
#![expect(missing_docs)]

use ef_tests::{cases::blockchain_test::BlockchainTests, suite::Suite};

Expand Down
Loading