Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): replace NodePrimitives trait with alloy_network::Network #10997

Closed
wants to merge 1 commit into from
Closed

chore(sdk): replace NodePrimitives trait with alloy_network::Network #10997

wants to merge 1 commit into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 18, 2024

Replaces NodePrimitives trait with alloy_network::Network

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Sep 18, 2024
@emhane emhane marked this pull request as draft September 18, 2024 17:18
@emhane emhane mentioned this pull request Sep 19, 2024
Closed
mattsse
mattsse reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a reth specific trait.
alloy network is not the right fit

@mattsse mattsse closed this Sep 19, 2024
@emhane emhane mentioned this pull request Sep 21, 2024
Merged
@emhane emhane deleted the emhane/alloy-node-primitives branch November 20, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse