feat: make NodeConfig generic over ChainSpec
#11039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
emhane,
onbjerg,
shekhirin and
joshieDo
as code owners
github-actions
bot
requested review from
rkrasiuk and
rakita
as code owners
mattsse
approved these changes
Sep 19, 2024
| /// All settings for how the node should be configured. | ||
| config: NodeConfig, | ||
| config: NodeConfig<ChainSpec>, |
There was a problem hiding this comment.
this makes sense and unblocks separation of Opchainspec and regular eth chainspec further, right?
| /// All settings for how the node should be configured. | ||
| config: NodeConfig, | ||
| config: NodeConfig<ChainSpec>, |
There was a problem hiding this comment.
there's perhaps an argument to make the entire config generic,so the builder can be used with custom config, but we should investigate this separately
Comment on lines
+73
to
+74
| #[derive(Debug)] | ||
| pub struct NodeConfig<ChainSpec> { |
There was a problem hiding this comment.
this is a bit unpleasant, but can we impls Clone here manually, auto derive doesn't work for arc.
nvm saw it below
maybe we could also remove the Arc and require chainspec clone and expect that chainspec internally wraps the arc, but different discussion
klkvr
force-pushed
the
klkvr/generic-config
branch
from
9ad110a to
57b7ab5
Compare
joshieDo
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10978
Towards #10909
Makes
NodeConfiggeneric over chainspec, allowing us to forward custom chainspecs parsed from CLI into NodeBuilder.For now still requires concrete
ChainSpecin several places including RPC and networking configuration