Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bin): make experimental engine default #11612

Merged
merged 10 commits into from
Oct 10, 2024
Merged

feat(bin): make experimental engine default #11612

merged 10 commits into from
Oct 10, 2024

Conversation

shekhirin
Copy link
Collaborator

Closes #11609

@shekhirin shekhirin added C-enhancement New feature or request A-cli Related to the reth CLI labels Oct 9, 2024
@shekhirin shekhirin marked this pull request as ready for review October 9, 2024 14:10
@shekhirin shekhirin changed the title feat(bin): make experimental engine default DO NOT MERGE: feat(bin): make experimental engine default Oct 9, 2024
@shekhirin shekhirin marked this pull request as draft October 9, 2024 14:49
rkrasiuk
rkrasiuk reviewed Oct 10, 2024
View reviewed changes
bin/reth/src/main.rs Outdated Show resolved Hide resolved
rkrasiuk
rkrasiuk previously requested changes Oct 10, 2024
View reviewed changes
bin/reth/src/main.rs Show resolved Hide resolved
bin/reth/src/main.rs Outdated Show resolved Hide resolved
bin/reth/src/main.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin requested a review from rkrasiuk October 10, 2024 11:22
@mattsse mattsse marked this pull request as ready for review October 10, 2024 12:47
@shekhirin shekhirin changed the title DO NOT MERGE: feat(bin): make experimental engine default feat(bin): make experimental engine default Oct 10, 2024
@mattsse mattsse added this pull request to the merge queue Oct 10, 2024
@shekhirin shekhirin removed this pull request from the merge queue due to a manual request Oct 10, 2024
@shekhirin shekhirin force-pushed the alexey/engine-experimental-default branch from 07c44ad to 73a37fe Compare October 10, 2024 14:50
@mattsse mattsse enabled auto-merge October 10, 2024 14:59
@mattsse mattsse added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit d027b7b Oct 10, 2024
39 checks passed
@mattsse mattsse deleted the alexey/engine-experimental-default branch October 10, 2024 15:16
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
@shekhirin
feat(bin): make experimental engine default (paradigmxyz#11612)
772c1b4
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
@shekhirin @reymom
feat(bin): make experimental engine default (paradigmxyz#11612)
5da3572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@fgimenez fgimenez Awaiting requested review from fgimenez

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make --engine.experimental default and introduce --engine.legacy instead
4 participants
@shekhirin @mattsse @rkrasiuk @emhane