docs: move ExEx book examples #11616
Conversation
shekhirin
added
C-docs
| Ok(()) | ||
| } | ||
|
|
||
| // ANCHOR: snippet |
There was a problem hiding this comment.
do we need this? and in other places too
There was a problem hiding this comment.
I wanted to show only the relevant sections of the files at the book references, and allow the reader to expand the complete file only if they want to. Another way to do this is to use line numbers of the snippets instead of using these // ANCHOR: snippet comments, but then we'd have to change the line numbers if the examples are changed. Or I could just show the complete files at all references. Which one do you prefer?
There was a problem hiding this comment.
oh, i see! that's great, I think these anchors are fine
| @@ -0,0 +1,4 @@ | |||
| fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| tonic_build::compile_protos("proto/exex.proto")?; | |||
There was a problem hiding this comment.
for this to work in the CI, we also need to install protoc. I think it's not a big deal as it's quite lightweight, wdyt @mattsse ?
There was a problem hiding this comment.
refactoring the job and adding protoc in #11618
There was a problem hiding this comment.
why does this need to run on ci?
yeah I guess if we want to do have well maintained bindings then we're kinda forced to do this. sounds reasonable
…cekaya/reth into move-exex-book-examples
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Closes #11581
Code examples in ExEx book chapters
RemoteandTracking Stateare moved to Rust files. There are small fixes for the examples that weren't working, and a new filebuild.rsto make the proto file in theRemoteexample compile. Otherwise, the example wasn't working as explained here.