feat(exex): commit only notifications with unfinalized blocks to WAL #11638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
requested review from
onbjerg,
rkrasiuk,
mattsse and
Rjected
as code owners
|
Tested on Holesky by unwinding 200 blocks and forcing the pipeline sync on restart, works as expected. |
vandenbogart
pushed a commit
to testmachine-ai/reth
that referenced
this pull request
Oct 14, 2024
reymom
pushed a commit
to reymom/reth
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAL should contain only notifications with unfinalized blocks. When syncing using the pipeline, all blocks will be finalized, so there's no need to write them to WAL.
This PR checks that the notification is coming from the blockchain tree (hence it's unfinalized), and only then proceeds to writing the notification to WAL.