feat(trie): sparse trie #11741
Merged
feat(trie): sparse trie #11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-enhancement
rkrasiuk
force-pushed
the
rkrasiuk/sparse-trie-impl
branch
2 times, most recently
from
ad10200
to
476073e
Compare
shekhirin
approved these changes
Oct 15, 2024
| } | ||
|
|
||
| fn reveal_node_or_hash(&mut self, path: Nibbles, child: &[u8]) -> alloy_rlp::Result<()> { | ||
| if child.len() == B256::len_bytes() + 1 { |
There was a problem hiding this comment.
can we add a comment here that if the length is 33 bytes, then it's an RLP-encoded string, and we need to skip the first byte that is the length of the string
Comment on lines
+258
to
+272
| if root_rlp.len() == B256::len_bytes() + 1 { | ||
| B256::from_slice(&root_rlp[1..]) | ||
| } else { |
There was a problem hiding this comment.
do you think it worths moving this to a separate function in alloy-trie? this happens often and it's not straight away obvious why is it needed
rkrasiuk
force-pushed
the
rkrasiuk/sparse-trie-impl
branch
from
c42b0a6
to
c147b01
Compare
shekhirin
approved these changes
Oct 15, 2024
reymom
pushed a commit
to reymom/reth
that referenced
this pull request
Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial sketch of
SparseTrieandStateSparseTrierepresenting partially loaded Ethereum state trie.