Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flashbots_validateBuilderSubmissionV4 #12243

Merged
merged 2 commits into from
Nov 1, 2024
Merged

feat: flashbots_validateBuilderSubmissionV4 #12243

merged 2 commits into from
Nov 1, 2024

Conversation

ryanschneider
Copy link
Contributor

@ryanschneider ryanschneider commented Oct 31, 2024 •
edited
Loading

This builds on #12168 and adds the new V4 RPC for Pectra.

klkvr
klkvr approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanschneider
Copy link
Contributor Author

I added a _v4 unit test (and renamed the old test _v3). Happy to consider any ideas for removing duplicate code, I tried adding an intermediate method like ValidationApi::validate_rpc_params(payload, sidecar, bid_trace, registered_gas_limit) -> RpcResult<()>) but it felt weird having a method in ValidationApi return an RpcResult when all the other core methods return Result<(), ValidationApiError> and it didn't save that much repetition.

@ryanschneider ryanschneider marked this pull request as ready for review November 1, 2024 20:23
mattsse
mattsse approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
fine with the duplicated test, we can likely make this nicer but should be separate

@mattsse mattsse added this pull request to the merge queue Nov 1, 2024
@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Nov 1, 2024
Merged via the queue into paradigmxyz:main with commit d8bbd36 Nov 1, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanschneider @mattsse @klkvr