chore(sdk): Add NodePrimitives::Transaction and NodePrimitives::SignedTx
#12330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
fgimenez and
onbjerg
as code owners
mattsse
reviewed
Nov 5, 2024
crates/node/types/src/lib.rs
Outdated
Comment on lines
27
to
30
| /// Signed version of the transaction type. | ||
| type SignedTx; | ||
| /// Transaction type. | ||
| type Transaction; |
There was a problem hiding this comment.
should those be integrated into a Block trait instead, because for block we also need those, right?
There was a problem hiding this comment.
think it makes sense to have these parallel to block too, so we can ref them without the trait bound Block on NodePrimitives::Block.
|
in which cases would we deal with an unsigned transaction? I believe only signed transactions are sent over p2p and stored in database |
klkvr
approved these changes
Nov 8, 2024
mattsse
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11253, #11240