refactor: use DBProvider
in HistoricalStateProvider
#12556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
HistoricalStateProvider
accepts both database transactions and aStaticFileProvider
.StaticFileProvider
is used twice: inBlockHashReader
impl which is identical to the one we have forDatabaseProvider
and to fetch chain tip which is identical toDatabaseProvider::last_block_number
This PR replaces tx and static_file_provider in
HistoricalStateProvider
with a single provider generic which is required to implementDBProvider
,BlockHashReader
andBlockNumReader
.The motivation here is that we'll need to add NodePrimitives generic to
StaticFilesProvider
and there's no need to introduce those generics to state providers.