Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant check in bodies stage #12569

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 15, 2024

Since #7137 we now have the consistency check right in increment_block, so returned block number would always be equal to the expected_block_number.

This allows to remove redundant error variant

cc @joshieDo for sanity check

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 56826cb Nov 15, 2024
41 checks passed
@mattsse mattsse deleted the klkvr/rm-redundant-error branch November 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants