Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Add InMemorySize as super trait #12615

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

htiennv
Copy link
Contributor

@htiennv htiennv commented Nov 17, 2024

Closes #12589.

@Gerson2102
Copy link
Contributor

Gerson2102 commented Nov 17, 2024

Seems like the contributors of this project does not have a minimum of respect when an issue is already assigned. @htiennv

@htiennv
Copy link
Contributor Author

htiennv commented Nov 18, 2024

ah sorry, i didn't see anyone assigned before doing this pr

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Collaborator

mattsse commented Nov 18, 2024

sorry about this @Gerson2102, happens sometimes

@mattsse mattsse added this pull request to the merge queue Nov 18, 2024
Merged via the queue into paradigmxyz:main with commit 378e097 Nov 18, 2024
40 checks passed
@htiennv htiennv deleted the trait branch November 18, 2024 12:59
@htiennv
Copy link
Contributor Author

htiennv commented Nov 18, 2024

sorry @Gerson2102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InMemorySize super trait
3 participants