Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove TransactionSignedNoHash #13120

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: remove TransactionSignedNoHash #13120

merged 1 commit into from
Dec 4, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 4, 2024

This is now unused

mattsse
mattsse approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah

@mattsse
Copy link
Collaborator

mattsse commented Dec 4, 2024

failing CI due to missing test vector on this pr

@mattsse mattsse merged commit 5c07669 into main Dec 4, 2024
40 of 42 checks passed
@mattsse mattsse deleted the klkvr/rm-no-hash branch December 4, 2024 07:59
@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse