Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export used deps from reth-codecs #13167

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 5, 2024

makes it unnecessary to also import modular-bitfield.

this still doesn't work due to generated code like this

couldn't find where this is generated,
we'd need to do generate the path manually so we don't have ::modular_bitfield but modular_bitfield, but couldn't find out where this is + concat happens or where bytes comes from

  pub struct StoredBlockBodyIndicesFlags {
            bytes: [::core::primitive::u8; {
                ((({
                    0usize + <B4 as ::modular_bitfield::Specifier>::BITS
                        + <B4 as ::modular_bitfield::Specifier>::BITS
                } - 1) / 8) + 1) * 8
            } / 8usize],
        }

Update: this is derived code from modular_bitfield so we can't easily get rid of this but should still use private re-exports in case this changes

@mattsse mattsse marked this pull request as ready for review December 6, 2024 08:21
@mattsse mattsse requested a review from joshieDo as a code owner December 6, 2024 08:21
@mattsse mattsse added the A-db Related to the database label Dec 6, 2024
@mattsse mattsse merged commit da98285 into main Dec 6, 2024
41 checks passed
@mattsse mattsse deleted the matt/make-reth-codecs-self-contained branch December 6, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants