Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EthApi traits abstraction #13170

Merged
merged 6 commits into from
Dec 6, 2024
Merged

feat: EthApi traits abstraction #13170

merged 6 commits into from
Dec 6, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 6, 2024

This completes most of the abstraction for eth namespace traits.

Changes include:

  • Header generic is added to EthApiServer
  • LoadPendingBlock is refactored so that header and block construction are handled by a separate assemble_block method and can be defined separately for OP and eth. Eventually this should be refactored to use payload builder instead

This should unblock abstraction of other namespaces implementations. The latest not abstracted endpoint for eth namespace is eth_simulateV1 which also requires building blocks, I'll work on it in a separate PR

@klkvr klkvr changed the title feat: EthApi traits abstaction feat: EthApi traits abstraction Dec 6, 2024
@mattsse mattsse added the A-rpc Related to the RPC implementation label Dec 6, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fantastic,

there are things we can try to make nicer soon, but for now this is a big unlock

@klkvr klkvr force-pushed the klkvr/pending-block-prims branch from cb51d61 to 7d59f25 Compare December 6, 2024 12:16
@klkvr klkvr enabled auto-merge December 6, 2024 12:22
@klkvr klkvr added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit cf2a6a1 Dec 6, 2024
42 checks passed
@klkvr klkvr deleted the klkvr/pending-block-prims branch December 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants