Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes most of the abstraction for
eth
namespace traits.Changes include:
Header
generic is added toEthApiServer
LoadPendingBlock
is refactored so that header and block construction are handled by a separateassemble_block
method and can be defined separately for OP and eth. Eventually this should be refactored to use payload builder insteadThis should unblock abstraction of other namespaces implementations. The latest not abstracted endpoint for
eth
namespace iseth_simulateV1
which also requires building blocks, I'll work on it in a separate PR